Avoid zooming out when browsing styles if the preview mode is active #67190
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
talldan
requested review from
draganescu,
jameskoster,
jeryj,
ramonjd,
tellthemachines and
aaronrobertshaw
|
Size Change: +13 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
Using scaled zoom when previewing styles was supposed to "show more" of how the style affects the look of things. I suspect that the fact that we're in preview does not alter the fact that default scale is not showing much above the fold. But I do agree that it looks broken at the moment. |
tellthemachines
approved these changes
Nov 22, 2024
ramonjd
approved these changes
Nov 22, 2024
talldan
deleted the
fix/avoid-zooming-out-in-view-mode-when-browsing-styles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #67166
Avoids zooming out when browsing styles if the preview mode is active.
How?
Check if
isPreviewModeis active, and if so, don't enter zoom out.I expect it should never be possible to enter zoom out from the preview mode, so part of me wonders if this should be built-in to the
useZoomOuthook. Or alternatively (and maybe better) into thesetZoomLevelaction. Would be good to get opinions on that.Testing Instructions
Screenshots or screencast
Before
After